COR-704: Rebuild AssetFieldType with Shrine #57

toastercup · 2017-04-24T08:02:40Z

Purpose

This PR features:

Asset Updating
Thumbnail placeholders for non-image assets
Accepted/Supported File Types feature for file input field
Removes media_title functionality for dynamic path/location. This will be discussed with Justin + team. This feature introduced tech debt with little benefit, and also has pre-existing issues with asset updating.

JIRA

https://cb-content-enablement.atlassian.net/browse/COR-704

Steps to Take On Prod

Reseed ContentTypes

Changes

Changes to setup
- .env changes:
  - HOST is now FOG_HOST, to be more explicit
  - New: HOST_ALIAS is used during ContentType seeding to configure the CDN for Media Assets
  - New: S3_ACCESS_KEY_ID is self-explanatory, and is only for Beta's AssetFieldType. It was created as a replacement for AWS_ACCESS_KEY_ID, whose naming is too broad for what it's intended for.
  - New: S3_SECRET_ACCESS_KEY is self-explanatory, and is only for Beta's AssetFieldType for the same reasons as S3_ACCESS_KEY_ID.
  - The old AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY continue to be used for Legacy
  - Variables like S3_BUCKET_NAME are used both for Legacy and Beta. This can be changed in the future if need be, but right now they share the same credentials.
Architectural changes
- Lots!
Migrations
- N/A
Library changes
- cortex-plugins-core needs to be bumped prior to merging
Side effects
- N/A

Screenshots

Before
N/A
After
N/A

QA Links

http://web.cortex-1.development.c66.me/ (admin@cortexcms.org/welcome1)

How to Verify These Changes

Specific pages to visit
- Media
Steps to take
- Try various CRUD-y things:
  - Create Media using various filetypes: image + non-image
  - Make sure you can update/overwrite existing Media with a new Asset
  - Try replacing an existing asset with a file of a different type (i.e. PNG -> PDF)
- Ensure asset is uploaded to S3 (Amazon S3 > cb-talent-development-cortex-dev > asset)
- Ensure asset link is generated using CDN
- Ensure thumbnails/versions are generated and uploaded correctly
- Ensure Media can be referred to by Blog (WYSIWYG Media insertion + Featured Media selection)
Responsive considerations
- N/A

Relevant PRs/Dependencies

cortex-cms/cortex#488

Additional Information

We should discuss threading
This PR implements almost 1:1 feature parity with our Paperclip implementation, but there are several gaps to discuss

… using Shrine

…asset deletion, misc

…generic FileUploader implementation

…e asset support, styling refactors, misc

…error fix

…ype processing

arelia · 2017-04-26T15:32:16Z

app/assets/stylesheets/cortex-plugins-core/components/thumbnail-placeholder.scss

@@ -0,0 +1,12 @@
+.thumbnail-placeholder {
+  background-color: #E4E4E4; // TODO: determine how to inherit variables from Cortex. This should be $color-grey-evenlighter


A separate style library?

@arelia That'd do it! It was late that night.. We should get started on that ASAP for V3.

arelia · 2017-04-26T15:38:26Z

I can successfully edit an asset and replace it with a different file type and update title, but I get a "Title Title Must Be Unique" error message

The original file was a PDF with a title like "Hiring Dot Nav".

It appears to have successfully been replaced with the space image and the "Space is Unique" title

toastercup · 2017-04-26T15:39:48Z

@arelia I noticed this as well, and actually added a comment to our code that this 'text uniqueness' feature does not work when you're updating an existing ContentItem's title. This was a pre-existing bug and is being documented in JIRA. Thanks for being thorough, though!

ElliottAYoung · 2017-04-26T15:40:02Z

app/assets/stylesheets/cortex-plugins-core/components/thumbnail-placeholder.scss

@@ -0,0 +1,12 @@
+.thumbnail-placeholder {
+  background-color: #E4E4E4; // TODO: Abstract to cortex-style-base library. This should be $color-grey-evenlighter


Even before the style base for Cortex is founded could you please extract this so we can just copy and paste the variables when the time comes

Sure - I'll just copy all variables from cortex to cortex-plugins-core, with the expectation that these need to be removed once cortex-plugins-core can pull from a cortex-style-base. Thanks!

ElliottAYoung · 2017-04-26T15:43:30Z

@toastercup Should we expedite the title bug @arelia mentioned to the next sprint, it seems like something that should be addressed before V2 is released

toastercup · 2017-04-26T15:44:07Z

@ElliottAYoung Yes - there's actually several bugs I uncovered that I'm going to push to be addressed next sprint

…tyle-base), uppercase thumbnail placeholder text

toastercup added 12 commits April 17, 2017 16:21

feat: initial stages of Paperclip-based AssetFieldType system rebuild…

59748b2

… using Shrine

feat: versions in AssetFieldType data hash

ef3a60e

feat: set metadata context for validation, do not destroy files upon …

dc016a7

…asset deletion, misc

refactor: extract versions_data from AssetFieldType data method

0b84fa5

feat: index, edit partials for new AssetFieldType backend

69e399a

fix: asset URL copy functionality

2043085

refactor: extract logic from AssetFieldType data setter, prepare for …

15c0324

…generic FileUploader implementation

feat: configurable AssetFieldType storage (S3 + Filesystem), non-imag…

e786706

…e asset support, styling refactors, misc

feat: AssetFieldType CDN support, S3 access control support, styling …

7ccd5a6

…error fix

feat: dynamic AssetFieldType versions

bd48fb6

feat: AssetFieldType dynamic validations

aa2dd70

feat: preliminary AssetFieldType dynamic path generation

91df5ea

toastercup added don't merge enhancement infrastructure technical debt labels Apr 24, 2017

toastercup requested review from ElliottAYoung, MKwenhua and arelia April 24, 2017 08:02

toastercup added 2 commits April 25, 2017 17:59

feat: dynamic AssetFieldType paths

fc79a15

fix: correctly generate hash of versions during non-image AssetFieldT…

cc5f334

…ype processing

toastercup force-pushed the topic/COR-704-Rebuild-AssetFieldType branch from baa3b6c to cc5f334 Compare April 26, 2017 00:07

toastercup mentioned this pull request Apr 26, 2017

COR-704: Rebuild AssetFieldType cortex-cms/cortex#488

Merged

fix: associated ContentItem issues with new AssetFieldType

233f7fa

toastercup requested a review from mrfantasticwonders April 26, 2017 14:59

arelia reviewed Apr 26, 2017

View reviewed changes

chore: update a todo comment to reflect latest plans

dc23296

arelia approved these changes Apr 26, 2017

View reviewed changes

ElliottAYoung approved these changes Apr 26, 2017

View reviewed changes

ElliottAYoung mentioned this pull request Apr 26, 2017

COR-667: Media Assets Not Updating #50

Closed

toastercup and others added 4 commits April 26, 2017 11:00

feat: drop in variables from cortex (to eventually be abstracted to s…

34c9ad2

…tyle-base), uppercase thumbnail placeholder text

chore: bump to v0.12.0

81d6919

Merge branch 'develop' into topic/COR-704-Rebuild-AssetFieldType

5fec220

refactor: loosen gemspec version requirements, bump to v0.12.1

52f03cc

toastercup force-pushed the topic/COR-704-Rebuild-AssetFieldType branch from 5385eb9 to 52f03cc Compare April 26, 2017 16:11

MKwenhua approved these changes Apr 26, 2017

View reviewed changes

toastercup merged commit 620749f into develop Apr 26, 2017

toastercup deleted the topic/COR-704-Rebuild-AssetFieldType branch April 26, 2017 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

COR-704: Rebuild AssetFieldType with Shrine #57

COR-704: Rebuild AssetFieldType with Shrine #57

Uh oh!

toastercup commented Apr 24, 2017 •

edited

Loading

Uh oh!

arelia Apr 26, 2017

Uh oh!

toastercup Apr 26, 2017

Uh oh!

arelia commented Apr 26, 2017

Uh oh!

toastercup commented Apr 26, 2017

Uh oh!

ElliottAYoung Apr 26, 2017

Uh oh!

toastercup Apr 26, 2017

Uh oh!

ElliottAYoung commented Apr 26, 2017

Uh oh!

toastercup commented Apr 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,12 @@
		.thumbnail-placeholder {
		background-color: #E4E4E4; // TODO: determine how to inherit variables from Cortex. This should be $color-grey-evenlighter

		@@ -0,0 +1,12 @@
		.thumbnail-placeholder {
		background-color: #E4E4E4; // TODO: Abstract to cortex-style-base library. This should be $color-grey-evenlighter

COR-704: Rebuild AssetFieldType with Shrine #57

COR-704: Rebuild AssetFieldType with Shrine #57

Uh oh!

Conversation

toastercup commented Apr 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

JIRA

Steps to Take On Prod

Changes

Screenshots

QA Links

How to Verify These Changes

Relevant PRs/Dependencies

Additional Information

Uh oh!

arelia Apr 26, 2017

Choose a reason for hiding this comment

Uh oh!

toastercup Apr 26, 2017

Choose a reason for hiding this comment

Uh oh!

arelia commented Apr 26, 2017

Uh oh!

toastercup commented Apr 26, 2017

Uh oh!

ElliottAYoung Apr 26, 2017

Choose a reason for hiding this comment

Uh oh!

toastercup Apr 26, 2017

Choose a reason for hiding this comment

Uh oh!

ElliottAYoung commented Apr 26, 2017

Uh oh!

toastercup commented Apr 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toastercup commented Apr 24, 2017 •

edited

Loading