Skip to content

Conversation

@ElliottAYoung
Copy link
Contributor

@ElliottAYoung ElliottAYoung commented May 10, 2017

Purpose:

See #416

This sets the stage and makes the necessary changes to update Cortex's elastic search from 2.4.1 to 5.4.0. Changes in this PR include:

  • Bump Cortex Plugin to new version for Beta Cortex ES compatibility
  • Update publish_filter ES query to work with 5.4.0 syntax
  • Remove pesky deprecation warnings

Before we start building our wonderful mappings, queries, filters and sorts for Beta Cortex, we need to upgrade ElasticSearch from 2.x to 5.x, so that we don't have to reinvent these queries in 6 months when we're forced to upgrade for some feature we need.

JIRA:

https://cb-content-enablement.atlassian.net/browse/COR-734

Steps to Take On Prod

  • Go through our API Endpoints and all pages in Legacy
  • Confirm that the page isn't failing
  • Confirm that the data matches expectation

Changes:

  • Changes to setup

    • N/A
  • Architectural changes

    • N/A
  • Migrations

    • N/A
  • Library changes

    • Prepares ES to update from 2.4.1 to 5.4.0
    • Bumps cortex-plugins-core to 0.12.4
  • Side effects

    • N/A

Screenshots

  • Before
    N/A

  • After
    N/A

QA Links:

http://web.cortex-6.development.c66.me

How to Verify These Changes

  • Specific pages to visit

    • All API endpoints
    • Literally every page in Legacy
  • Steps to take

    • Go through our API Endpoints
    • Confirm that the page isn't failing
    • Confirm that the data matches expectation
  • Responsive considerations

    • N/A

Relevant PRs/Dependencies:

N/A

Additional Information

N/A

@arelia
Copy link
Contributor

arelia commented May 11, 2017

Server is down, redeploying

@arelia
Copy link
Contributor

arelia commented May 22, 2017

@ElliottAYoung @toastercup does this need a push to at least stage before we can review (like testing endpoints and pages)? if so I'll hold off

@ElliottAYoung
Copy link
Contributor Author

@arelia no - this can be tested in any environment
I technically have a server up with these changes live at http://web.cortex-6.development.c66.me

@arelia
Copy link
Contributor

arelia commented May 23, 2017

@ElliottAYoung ok, I was thinking we needed to test pages and endpoints with more content.

I'm testing on your dev env and I don't see all 4 posts here: http://web.cortex-6.development.c66.me/api/v1/posts/feed?per_page=100

I'm expecting cache needs to clear and I have to wait for it. Will try in the morning

@ElliottAYoung
Copy link
Contributor Author

@arelia make sure those posts are published, the feed endpoint only shows posts that have a published date in the past

@ElliottAYoung ElliottAYoung merged commit 39d2e07 into develop May 26, 2017
@ElliottAYoung ElliottAYoung deleted the topic/COR-772-Upgrade-ES-to-5.x branch May 26, 2017 14:28
toastercup added a commit that referenced this pull request May 26, 2017
…-5.x"

This reverts commit 39d2e07, reversing
changes made to 2c57097.
@ElliottAYoung ElliottAYoung restored the topic/COR-772-Upgrade-ES-to-5.x branch May 31, 2017 20:52
ElliottAYoung added a commit that referenced this pull request May 31, 2017
@toastercup toastercup deleted the topic/COR-772-Upgrade-ES-to-5.x branch July 5, 2017 22:11
toastercup pushed a commit that referenced this pull request Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants