Skip to content

Conversation

@ElliottAYoung
Copy link
Contributor

@ElliottAYoung ElliottAYoung commented May 18, 2017

Purpose:

Fixes our sorting logic for the posts feed so that if the published filter is applied the total set of posts are sorted by the published_at date, rather than the created_at date. Leaves the expected return the same on legacy cortex.

AR-67:

Articles on the filtered landing pages (Discovery, Get the Job, etc.) are not in order of the date published and we would like them to be, similar to the A&R homepage.

AR-68

Ensure all searches for A&R deliver results by the visible, published date on a post - NOT the create date or modified date.

JIRA:

Steps to Take On Prod

  • Go to /api/v1/posts/feed?per_page=100 (several per page to prove behavior)
  • Confirm that, with the notable exception of sticky posts, the posts are in order of publish date, with the most recent being at the top

Changes:

  • Changes to setup

    • Rework ES logic for Posts
  • Architectural changes

    • ^
  • Migrations

    • N/A
  • Library changes

    • N/A
  • Side effects

    • N/A

Screenshots

  • Before
    N/A

  • After
    N/A

QA Links:

http://web.cortex-6.development.c66.me/ (Having deploy issues ATM)

How to Verify These Changes

  • Specific pages to visit

    • /api/v1/posts/feed?per_page=100
  • Steps to take

    • Confirm that, with the exception of sticky posts, the posts are sorted by Published Date, with the most recent at the top.
  • Responsive considerations

    • N/A

Relevant PRs/Dependencies:

#495: Upgrading Cortex to ES 5.4.0, which this is fully compatible with

Additional Information

N/A

@toastercup
Copy link
Member

@ElliottAYoung C66 is failing to deploy because the Gemfile.lock is not in sync with the Gemfile in the branch that this PR branches off of - topic/COR-772-Upgrade-ES-to-5.x. Please sync on that branch and then rebase + rebuild. Thanks!

Copy link
Member

@toastercup toastercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile/Gemfile.lock sync necessary

@ElliottAYoung ElliottAYoung force-pushed the bugfix/AR-67+68-Publish-Date-Sorting-Kerfuffles branch from 7e664b0 to 6438fc2 Compare May 22, 2017 15:05
@ElliottAYoung
Copy link
Contributor Author

@ElliottAYoung ElliottAYoung merged commit 17a9696 into topic/COR-772-Upgrade-ES-to-5.x May 23, 2017
@ElliottAYoung ElliottAYoung deleted the bugfix/AR-67+68-Publish-Date-Sorting-Kerfuffles branch May 23, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants