Update to allow configurable max message size for querier.

[jtlisi]

No description provided.

[tomwilkie]

LGTM!

[tomwilkie]

Ideally this would be part of weaveworks/common/server, but there is precedent for this: #679

[tomwilkie]

LGTM x2.

[bboreham]

Is it the max send size or max recv size? The code says both.
We already have the latter in the ingester -

cortex/pkg/ingester/client/client.go

Line 91 in 8d9c36e

f.IntVar(&cfg.MaxRecvMsgSize, "ingester.client.max-recv-message-size", 64*1024*1024, "Maximum message size, in bytes, this client will receive.")

[gouthamve]

Would be good to mention the units, i.e, size of a grpc message, in bytes, ...

[bboreham]

Why is it the server receiving size you care about, as opposed to the client? (Or server send)

[tomwilkie]

Why is it the server receiving size you care about, as opposed to the client? (Or server send)

When using the query-frontend, the querier creates a gRPC streaming connection to it, requests are pushed down from server (frontend) to client (querier) and responses are pushed from client (querier) to server (frontend). We hit an issue where large query responses exceeded the limit for messages received by the frontend.

[bboreham]

Can we have a commit message that more closely describes the intent, e.g. "add command-line option to ..." please.

[bboreham]

Thanks!