Add gRPC MaxConcurrentStreams limit and flag#679
Merged
Conversation
Merged
Plausibly this should be in weaveworks/common/server, but I wanted to try it out more locally first.
bboreham
force-pushed
the
limit-max-streams
branch
from
45a2c5d to
8bb48f6
Compare
jml
approved these changes
Feb 7, 2018
Contributor
Author
|
Was added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #672 - believe that limiting the number of streams would stop the infinite blow-up of goroutines, though not really fix the underlying problem.
Plausibly this should be in weaveworks/common/server, but I wanted to try it out more locally first.