Conversation
grpc.WithTimeout() is documented to only do anything if grpc.WithBlock() also supplied, and we do not supply that. Even then, it puts a timeout on the Dial() operation, which is not what we want.
bboreham
force-pushed
the
ingester-timeouts
branch
from
f57209b to
bb4a1f0
Compare
jml
approved these changes
Feb 7, 2018
Contributor
jml
left a comment
jml
left a comment
There was a problem hiding this comment.
Nice, thanks. This will make the code easier to follow.
Contributor
|
The Dial can block for a long time, and its a bad place to block. Can we use grpc.DialContext? |
Contributor
Author
|
@tomwilkie I don't understand your point. This |
Contributor
|
Has gRPC changed since we wrote this code? Its used to be the case that would block. IIRC that would happen when it couldn't resolve the targets. |
Contributor
|
It indeed has changed, see:
So you can ignore me. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove code that appears to set a timeout but actually does nothing, set a timeout on each call to
Push()in the distributor, and set a timeout on entire rule-group evaluation in the ruler.This is a plausible fix for #672, but see also #679