Don't fetch chunks outside our timerange#149
Merged
Conversation
jml
approved these changes
Nov 22, 2016
chunk/chunk_store.go
Outdated
| return nil, err | ||
| } | ||
| if chunkThrough < from || through < chunkFrom { | ||
| fmt.Println(chunkThrough, from, through, chunkFrom) |
Contributor
There was a problem hiding this comment.
Guessing this Println is there for debugging. Please remove or turn into a proper log call.
| queryChunks.Observe(float64(len(missing))) | ||
| filtered := make([]Chunk, 0, len(chunks)) | ||
| for _, chunk := range chunks { | ||
| _, chunkFrom, chunkThrough, err := parseChunkID(chunk.ID) |
Contributor
There was a problem hiding this comment.
I realise the from & through terminology was present before this PR, but I think start & end would be better. Up to you whether you want to change in this PR.
Contributor
Author
There was a problem hiding this comment.
I actually like from & through - end tends to be a reserved word in many languages, and through implies inclusivity.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with #132