Add Alertmanager Integration Tests and Static File Backend#2125
Merged
jtlisi merged 3 commits intocortexproject:masterfrom Feb 17, 2020
jtlisi:20190916_file_backed_alertmanager
Merged
Add Alertmanager Integration Tests and Static File Backend#2125jtlisi merged 3 commits intocortexproject:masterfrom jtlisi:20190916_file_backed_alertmanager
jtlisi merged 3 commits intocortexproject:masterfrom
jtlisi:20190916_file_backed_alertmanager
Conversation
Contributor
Author
|
@pracucci I updated this PR to utilize Go Integration tests. I also re-opened the PR from my github account due to some configs on the Grafana CircleCI account affecting the integration tests. Specifically the |
2 tasks
jtlisi
changed the title
pracucci
approved these changes
Feb 17, 2020
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## master / unreleased | |||
Contributor
There was a problem hiding this comment.
I just realized we didn't mention the introduction of the local storage in the changelog. I think it's worth to mention it.
CHANGELOG.md
Outdated
| * `--experimental.distributor.user-subring-size` | ||
| * [FEATURE] Added flag `-experimental.ruler.enable-api` to enable the ruler api which implements the Prometheus API `/api/v1/rules` and `/api/v1/alerts` endpoints under the configured `-http.prefix`. #1999 | ||
| * [FEATURE] Added sharding support to compactor when using the experimental TSDB blocks storage. #2113 | ||
| * [ENHANCEMENT] Add `status` label to `cortex_alertmanager_configs` metric to guage the number of valid and invalid configs. #2125 |
Contributor
|
The lint issue is unrelated from this PR, but if you rebase |
… integration test for alertmananger Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Contributor
|
Should #1647 be closed by this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carried over from #1686 due to CircleCI configs for branches based in the grafana repo affecting integration tests.
Overview
Important Detail
pkg/alertmanager/multitenant_test.gois run with!racetag because of an underlying mild race condition in the Alertmanager.https://github.com/prometheus/alertmanager/issues/2182Related
#1647
#1244
#1513
#619