Design doc - Generalize Module Service#2542
Merged
pracucci merged 4 commits intocortexproject:masterfrom May 5, 2020
Merged
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
jtlisi
reviewed
Apr 30, 2020
jtlisi
reviewed
Apr 30, 2020
jtlisi
reviewed
Apr 30, 2020
jtlisi
reviewed
Apr 30, 2020
pstibrany
reviewed
Apr 30, 2020
This was referenced Apr 30, 2020
Signed-off-by: Annanay <annanayagarwal@gmail.com>
cyriltovena
approved these changes
May 4, 2020
pracucci
approved these changes
May 4, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM (I left few super minor comments)
pstibrany
approved these changes
May 5, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
I left some small comments but LGTM overall.
Co-authored-by: Marco Pracucci <marco@pracucci.com> Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
annanay25
force-pushed
the
modules-proposal
branch
from
79e8236 to
7cce7ba
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
This PR adds an initial draft for a design document proposing generalizing the module service.
Which issue(s) this PR fixes:
Part of #2291
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]