Only wait for other modules if underlying service is still running.#2547
Merged
pstibrany merged 1 commit intocortexproject:masterfrom Apr 30, 2020
pstibrany:module-service
Merged
Only wait for other modules if underlying service is still running.#2547pstibrany merged 1 commit intocortexproject:masterfrom pstibrany:module-service
pstibrany merged 1 commit intocortexproject:masterfrom
pstibrany:module-service
Conversation
Otherwise there is no point in waiting. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
gouthamve
approved these changes
Apr 30, 2020
annanay25
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: While reviewing #2542, I've realized there is a small issue in
moduleService: it waits for other modules to stop, even if underlying service is already stopping or terminated. This PR fixes that. It doesn't change much: it will log module error earlier, and transition to Terminated/Failed state faster. More importantly, I think it makes intent of the code clearer.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]