Revert "Merge pull request #971 from grafana/batch-index-lookups"#980
Merged
tomwilkie merged 1 commit intocortexproject:masterfrom Sep 3, 2018
Merged
Revert "Merge pull request #971 from grafana/batch-index-lookups"#980tomwilkie merged 1 commit intocortexproject:masterfrom
tomwilkie merged 1 commit intocortexproject:masterfrom
Conversation
Contributor
|
Hmm, this is not master broken per-se right? It's just that the caching doesn't work. I'm not sure rolling-back is necessary right now given there is a PR with the fix already. |
Contributor
Author
|
Challenge is that the PR will probably be outstanding for a while, as it clearly deserves more scrutiny. And I don't want to leave master broken for a while. |
Contributor
|
Hmm, yeah. 👍 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0d275f0, reversing changes made to 1ffffff.
Revert because the index batching broke the index caching.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com