Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughReplaced the EthFlow Deployments subsection with an expanded, table-driven Environment table (Production/Staging and Lens-specific rows) and a dedicated warning block stressing correct-chain targeting and irrecoverable loss when sending native tokens to the wrong chain. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/cow-protocol/reference/contracts/periphery/README.mdx[style] ~24-~24: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase. (EN_WEAK_ADJECTIVE) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cow-protocol/reference/contracts/periphery/README.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cow-protocol/reference/contracts/periphery/README.mdx
[grammar] ~17-~17: There might be a mistake here.
Context: ...62d157E00D13419D2D6E95), but not Lens! | | Production | `0x5A5b8aE7a0b4C0EAf453d...
(QB_NEW_EN)
[grammar] ~18-~18: There might be a mistake here.
Context: ...7a0b4C0EAf453d10DCcfbA413f07ebdC2) only! | Staging | `0xFb337f8a725A142f65fb9...
(QB_NEW_EN)
[style] ~24-~24: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ... to irrecoverable loss of funds! Be very careful to choose the right address in the chai...
(EN_WEAK_ADJECTIVE)
Description
The current list of ETH-flow is highly misleading since it implies that the ETH-flow address is the same on Lens as for the other chains. Users relying on this address on Lens would lose their funds.
Changes
Other notes
I tried to make the table easier to review when adding networks in the future but I was unsuccessful. Options that could work would be to style this section with code (requires messing with React components, which I'm unfamiliar with) or relying on some relatively obscure package remark-grid-tables for better table formatting (idea from here).
How to review
Make sure all chains are included in the standard contract except for Lens.
Summary by CodeRabbit