Skip to content

fix: separate lens ethflow contract address#544

Closed
alfetopito wants to merge 1 commit intomainfrom
fix/lens-ethflow-contract
Closed

fix: separate lens ethflow contract address#544
alfetopito wants to merge 1 commit intomainfrom
fix/lens-ethflow-contract

Conversation

@alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Oct 16, 2025

Description

Split ethflow contract address table to be explicit the Lens address is not the same as other chains

https://docs.cow.fi/cow-protocol/reference/contracts/periphery previously showed only a single address for all chains, despite the network link pointing to a different one
image

Changes

image

@alfetopito alfetopito self-assigned this Oct 16, 2025
@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
docs Ready Ready Preview Oct 16, 2025 9:53am

@alfetopito
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

The periphery contracts documentation table is restructured to explicitly segment deployment environments by network coverage. Production and Staging environments are each split into "most chains" and "Lens" categories, relabeling existing addresses to clarify their network scope without changing the underlying values.

Changes

Cohort / File(s) Summary
Documentation table restructure
docs/cow-protocol/reference/contracts/periphery/README.mdx
Environment deployment table rewritten from 2 rows (Production, Staging) to 4 rows, adding explicit network-coverage labels (most chains vs. Lens) for each environment tier while preserving address values

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • cowprotocol/docs#538: Modifies the same periphery contracts README deployment table to add Lens-specific entries and clarify network coverage through similar restructuring.

Suggested reviewers

  • pretf00d
  • fhenneke

Poem

📚✨ A rabbit hops through docs so fine,
Rearranging rows in perfect line,
Production, staging—now split with care,
Lens and chains both labeled there! 🐰

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly captures the primary change by indicating that the Lens-specific ETHFlow contract address has been separated, aligning directly with the modifications made to the periphery README table. It is concise, clear, and focused on the main update without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description includes the required Description and Changes sections from the template. The Description section clearly explains the issue: the ethflow contract address table previously showed only a single address for all chains despite the network link pointing to a different Lens address. The Changes section includes a checkbox item with evidence (screenshots) showing the fix adds new entries for Lens. While the Related Issues section is not included, it appears to be optional based on the template's commented-out format, and the description provides sufficient context and rationale for the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/lens-ethflow-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@alfetopito alfetopito marked this pull request as ready for review October 16, 2025 09:55
@alfetopito alfetopito requested a review from a team as a code owner October 16, 2025 09:55
@fedgiac
Copy link
Contributor

fedgiac commented Oct 16, 2025

I suggest to use #543 instead to also update the warnings.

Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway, the changes look good and I'm happier to merge this if it makes the changes go out faster. 🙂

@alfetopito
Copy link
Contributor Author

I suggest to use #543 instead to also update the warnings.

Sorry I was not aware you created a PR before me.
Closing in favour of that one.

@alfetopito alfetopito closed this Oct 17, 2025
@alfetopito alfetopito deleted the fix/lens-ethflow-contract branch October 17, 2025 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants