Migrate from web3's SecretKey to alloy's PrivateKeySigner #3989
+200
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MartinquaXD
approved these changes
Dec 19, 2025
| EcdsaSigningScheme::Eip712, | ||
| &onchain.contracts().domain_separator, | ||
| SecretKeyRef::from(&SecretKey::from_slice(trader_a.private_key()).unwrap()), | ||
| &PrivateKeySigner::from_slice(trader_a.private_key()).unwrap(), |
Contributor
There was a problem hiding this comment.
Did you consider adjusting the private_key() function to already return a PrivateKeySigner? Don't know if we ever need to use the raw bytes NOT for initializing that type.
Contributor
Author
There was a problem hiding this comment.
This gets simplified in the following PR, I don't think it's worth changing it in this PR
https://github.com/cowprotocol/services/pull/3990/changes#diff-50c3d00f9ea51df4069a21538ee31003522aa16eb82084abb82ed6714ae91380L1078
squadgazzz
approved these changes
Dec 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start to set up the alloy signers etc, by removing the usage of SecretKey and SecretKeyRef
Changes
How to test
Existing tests