Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Dec 17, 2025

Description

Migrates the TestAccount structure to alloy by replacing the previous private key "infrastructure" with the alloy equivalent

Ironically, this kind of "undoes" a lot of work form #3989 but without it this PR wouldn't be as easy nor as "clean"

Changes

  • Remove the ethcontract insides from TestAccount
  • Add alloy's PrivateKeySigner
  • Refactor tests accordingly
  • Remove (now unneeded) TryIntoAlloy

How to test

Existing tests

@jmg-duarte jmg-duarte requested a review from a team as a code owner December 17, 2025 18:16
@jmg-duarte jmg-duarte marked this pull request as draft December 17, 2025 18:18
@jmg-duarte jmg-duarte marked this pull request as ready for review December 19, 2025 07:46
Base automatically changed from jmgd/alloy/signer to main December 19, 2025 09:34
@jmg-duarte jmg-duarte enabled auto-merge December 19, 2025 09:55
@jmg-duarte jmg-duarte added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 6e5dc96 Dec 19, 2025
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy/account branch December 19, 2025 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants