[PRO-401] add customProperties to OpenSession, CreateMessage event #2
+411
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanxyz
changed the title
This was referenced Mar 12, 2024
Merged
kde713
reviewed
Mar 13, 2024
src/utils.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
| import {EventProperties_CustomPropertyValue} from "./buf/event_pb"; | |||
|
|
|||
| export type CustomProperties = Record<string, string>; | |||
Contributor
There was a problem hiding this comment.
nit. util 보다는 event에서 필요한 타입에 가까워보이는데 events.ts 또는 types.ts (신규) 에 두는 편이 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts->js, d.ts로 변경되어서--allowJs추가했습니다.pnpm pack으로 패키지 만든 다음 다른 프로젝트에 설치해서 사용해본 결과 잘 작동하는 것을 확인했습니다.