[PRO-402] add customProperties to OpenSession, CreateMessage event #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanxyz
commented
Mar 12, 2024
nyanxyz
commented
Mar 13, 2024
| custom_properties=user_info.get("custom_properties", None), | ||
| ) | ||
|
|
||
| def add_message(self, message: BaseMessage) -> None: |
Contributor
Author
There was a problem hiding this comment.
add_message는 오버라이드 된 거라 argument를 변경할 수 없어 CustomProperties를 추가하지 않았는데 message 변수를 이용해서 CustomProperties를 지원해야 할까요??
(additional_kwargs, response_metadata 이용)
Contributor
There was a problem hiding this comment.
@nyanxyz Langchain, Llamaindex integration은 지금 고려하지 않아도 될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coxwave/alignai-sdk-node#2 와 동일