Skip to content

Conversation

@crazy-max
Copy link
Owner

@crazy-max crazy-max commented Sep 21, 2021

First spike to default buildx on docker/cli.

Don't take into account the GitHub Actions cross commit 31fe2f1. Just here to be able to produce temp artifacts in the workflow for testing.

cc @tonistiigi @thaJeztah

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 81b3d6b)
@crazy-max crazy-max force-pushed the buildx-def branch 2 times, most recently from e339bdd to 1e8e0a4 Compare September 21, 2021 10:16
@crazy-max
Copy link
Owner Author

crazy-max commented Sep 21, 2021

Message if buildx is missing or broken:

$ docker build .
failed to fetch metadata: fork/exec /usr/libexec/docker/cli-plugins/docker-buildx: no such file or directory

ERROR: Missing or broken buildx plugin. To install buildx, see
       https://docs.docker.com/buildx/working-with-buildx/#install. You can
       also fallback to the legacy builder with: DOCKER_BUILDKIT=0

@crazy-max crazy-max force-pushed the buildx-def branch 2 times, most recently from 5db84e6 to d21f8b1 Compare September 22, 2021 09:52
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Owner Author

Waiting for docker#3234 before creating a draft PR on docker/cli.

@tonistiigi
Copy link

Message if buildx is missing or broken:

We could do a better error without fork/exec but checking if the file exists.

Other error is expected. Maybe wording should be "Your docker installation is missing builder component buildx"

Fallback should be opt-in only. If there is no buildx then showing this message by default is correct.

@crazy-max crazy-max closed this Mar 15, 2022
crazy-max pushed a commit that referenced this pull request May 15, 2022
…onfig-20.10

[20.10] registry: ensure default auth config has address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants