Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 6, 2021

  • Switch To GitHub Actions for cross target
    • also store artifacts temporarly (90d by default in repo settings) in the workflow (can remove that if you want)
    • and build dynbinary cross
    • use GitHub Action cache backend
  • Cleanup bake definition that was specific to CircleCI
  • Restore binary target in Makefile for non-sandboxed build
  • Fix README with proper lint command using bake

Run: https://github.com/docker/cli/actions/runs/1103549570

image

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #3234 (d9f4352) into master (56e5910) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3234   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         302      302           
  Lines       21764    21764           
=======================================
  Hits        12621    12621           
  Misses       8219     8219           
  Partials      924      924           

@crazy-max crazy-max requested a review from thaJeztah August 9, 2021 16:57
@crazy-max
Copy link
Member Author

PTAL @thaJeztah @silvin-lubecki :)

@crazy-max crazy-max force-pushed the gha-build branch 2 times, most recently from e46442a to f8faa14 Compare September 3, 2021 13:05
@crazy-max
Copy link
Member Author

Removed GHA cache backend as we have issues with it.

@crazy-max
Copy link
Member Author

As discussed with @thaJeztah I restored the binary target to allow non-sandboxed build.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@silvin-lubecki PTAL

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit e978593 into docker:master Oct 1, 2021
@crazy-max crazy-max deleted the gha-build branch October 1, 2021 10:08
@thaJeztah thaJeztah added this to the 21.xx milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants