GitHub Actions e2e tests #3320
Merged
GitHub Actions e2e tests #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
gha-e2e
branch
2 times, most recently
from
1540ef7 to
f36c075
Compare
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
=======================================
Coverage 58.02% 58.02%
=======================================
Files 302 302
Lines 21761 21761
=======================================
Hits 12626 12626
Misses 8214 8214
Partials 921 921 |
crazy-max
force-pushed
the
gha-e2e
branch
4 times, most recently
from
b7135b4 to
cb6ba55
Compare
Member
Author
|
There seems to be some issues with the tests while using the Will try a replay to see if it's something on the GitHub Runner. Otherwise will revert to use Edit: Revert to |
crazy-max
force-pushed
the
gha-e2e
branch
6 times, most recently
from
96f76f8 to
ea7ff41
Compare
Member
Author
|
Not related to these changes but
|
Member
Author
crazy-max
force-pushed
the
gha-e2e
branch
9 times, most recently
from
d989020 to
f4f9644
Compare
crazy-max
force-pushed
the
gha-e2e
branch
4 times, most recently
from
77afbca to
cd1fd87
Compare
crazy-max
force-pushed
the
gha-e2e
branch
2 times, most recently
from
baf747a to
381a047
Compare
thaJeztah
reviewed
Nov 15, 2021
Comment on lines
+85
to
+86
| RUN curl -fsSL https://github.com/docker/compose/releases/download/${COMPOSE_VERSION}/docker-compose-$(uname -s)-$(uname -m) -o /usr/local/bin/docker-compose && \ | ||
| chmod +x /usr/local/bin/docker-compose |
Member
There was a problem hiding this comment.
It's a pity we need the uname -m here, but we can probably get rid of that if (in a follow-up) we switch to compose v2
Member
Author
There was a problem hiding this comment.
Yep looking forward for that :)
Comment on lines
-37
to
+28
| TARGET="${TARGET}.exe" | ||
| TARGET="${TARGET}.exe" |
Member
There was a problem hiding this comment.
Looks like #2993 messed up formatting of out scripts and changed tabs to spaces for indentation 😞
We should probably fix that again (perhaps add a shfmt check somewhere https://github.com/moby/moby/blob/d9e3d383f56119b0ba64ed63c6d5a265fbf35f7d/Dockerfile#L204-L209
Member
Author
There was a problem hiding this comment.
Ah yes indeed, we should add shfmt in a follow-up, good idea.
crazy-max
force-pushed
the
gha-e2e
branch
2 times, most recently
from
6e7d368 to
93d4540
Compare
thaJeztah
approved these changes
Nov 16, 2021
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
left one minor nit (but let me know if you prefer doing in a follow-up)
crazy-max
force-pushed
the
gha-e2e
branch
2 times, most recently
from
06f6a2d to
2e59cdb
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Member
Author
|
@thaJeztah Was trying to solve issues with the Seems to occur in https://github.com/moby/moby/blob/459d0dfbbb51fb2423a43655e6c62368ec0f36c9/plugin/fetch_linux.go#L206. Any idea @cpuguy83? Linked test Line 34 in a32cd16 |
Member
|
Reading from my phone, but I recall the "unknown type" error from moby/moby#42889 (haven't found the time to look into that one). Looks like we also need to add the local registry as "insecure registry" (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #3234
Switch To GitHub Actions for e2e tests:
binaryandpluginsscriptsGO_STRIPvarplugins-windowsandplugins-osxmerged to plugins scriptalpineandbusterbase variantsAlso use20.10-dindinstead ofstable-dindbecause it has not been updated for 10 months (19.03.15).Signed-off-by: CrazyMax crazy-max@users.noreply.github.com