feat: Add add/edit tags to sort-tags-row components#2690
Merged
ebiggz merged 1 commit intocrowbartools:v5from Aug 14, 2024
Merged
feat: Add add/edit tags to sort-tags-row components#2690ebiggz merged 1 commit intocrowbartools:v5from
ebiggz merged 1 commit intocrowbartools:v5from
Conversation
- Edits the tags popover menus to include add or add/edit tags menu options. - The padding and margin values look appropriate for me, but are open to be adjusted if desired.
phroggster
commented
Aug 14, 2024
| </div> | ||
| </script> | ||
| <div> | ||
| </div> |
Collaborator
Author
There was a problem hiding this comment.
psst. This one's worth an extra comment. I thought I had messed something up when I looked at the diff, so now you get to read this text and waste ten seconds.
ebiggz
approved these changes
Aug 14, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Love this, thanks for adding it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Applicable Issues
#2188
Testing
Yes.
Screenshots
Screenshot of an empty component lacking tags, atop a separate screenshot of a component with several tags available (manually blurred out for screenshot purposes):
