Skip to content

Comments

fix: OBS Scene Transition/Change Fixups#2748

Merged
ebiggz merged 3 commits intocrowbartools:v5from
phroggster:transition_started_eventing
Aug 27, 2024
Merged

fix: OBS Scene Transition/Change Fixups#2748
ebiggz merged 3 commits intocrowbartools:v5from
phroggster:transition_started_eventing

Conversation

@phroggster
Copy link
Collaborator

@phroggster phroggster commented Aug 27, 2024 •
edited
Loading

Description of the Change

  • Fix a bug where the OBS Program Scene Changed event was firing twice.
  • Fix a bug where OBS Transition Started event could not access the new $obsSceneName until after a Scene Changed event propagates once the scene transition fully completes.
    • This is likely a bug or oversight in OBS Websockets.
    • But it can be worked around by immediately querying for the new scene name once a Transition Started event is received.

Applicable Issues

#2749

Testing

Screenshots

@phroggster
fix: OBS Program Scene Changed double event
03a5a5e 
- I left in the original OBS_CURRENT_PROGRAM_SCENE_CHANGED_EVENT_ID
  invocation, but also added another. My mistake.
@phroggster
fix: OBS Transition Started missing Scene Name
4587a57 
- The scene changed event fires later, yet can be immediately queried
  from the SceneTransitionStarted event callback.
- So immediately query for it when a scene transition starts.
- Apologies, and thanks, to https://www.twitch.tv/ElieaLive
@phroggster phroggster requested a review from ebiggz as a code owner August 27, 2024 06:03
@ebiggz ebiggz merged commit e73a631 into crowbartools:v5 Aug 27, 2024
@phroggster phroggster deleted the transition_started_eventing branch August 27, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebiggz ebiggz ebiggz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phroggster @ebiggz