Skip to content

feat: add more verbose error to http request log #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zunderscore merged 3 commits into from
Dec 21, 2024
Merged

feat: add more verbose error to http request log #2935

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f03258
feat: add more verbose error to http request log
CKY- Dec 20, 2024
8a212ea
fix: null check responseData just in case
zunderscore Dec 21, 2024
ef5a028
Merge branch 'v5' into v5-error-messages-in-http-request
zunderscore Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/backend/effects/builtin/http-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ const axios = axiosDefault.create({
}
});

axios.interceptors.request.use(request => {
axios.interceptors.request.use((request) => {
//logger.debug('HTTP Request Effect [Request]: ', JSON.parse(JSON.stringify(request)));
return request;
});

axios.interceptors.response.use(response => {
axios.interceptors.response.use((response) => {
//logger.debug('HTTP Request Effect [Response]: ', JSON.parse(JSON.stringify(response)));
return response;
});
Expand Down Expand Up @@ -159,7 +159,7 @@ const effect = {
resolveObj: {
header: () => header
},
closeCallback: newHeader => {
closeCallback: (newHeader) => {
console.log(newHeader);
$scope.effect.headers = $scope.effect.headers.filter(h => h.key !== newHeader.key);
$scope.effect.headers.push(newHeader);
Expand Down Expand Up @@ -222,7 +222,7 @@ const effect = {
}
return errors;
},
onTriggerEvent: async event => {
onTriggerEvent: async (event) => {

const logger = require("../../logwrapper");
const twitchAuth = require("../../auth/twitch-auth");
Expand Down Expand Up @@ -284,7 +284,12 @@ const effect = {
);
}
} catch (error) {
logger.error("Error running http request", error.message);
const message = {
errorMessage: error.message,
responseData: error.response?.data
};

logger.error("Error running http request", message);

if (effect.options.runEffectsOnError && !abortSignal?.aborted) {
const processEffectsRequest = {
Expand Down
Loading