tokio + py03 async inferface contrib#9
Open
michaelfeil wants to merge 16 commits into
Open
Conversation
Mf/better ci
Collaborator
|
Thank you for your contribution! |
Contributor
Author
|
@AlonKejzman Hey, writing up this PR. If you want to use tokenizers from python, offload to asynchronous loop can help a lot. I noticed reviews take a bit of time - are you generally open to PRs? I am the one who contributed this feature in tokenizers, and thought it was missing. |
Collaborator
|
Please add benchmarks of something which this benefits - since it significantly complicates the code, we need good justification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR on the Py03 CI PR. #8 cc @AlonKejzman @biswapanda