Skip to content

Conversation

@lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Nov 12, 2024

  1. updated the .env.example file to reflect the default behavior of application.rb

This changed fixes amber being stuck trying to redirect the user to sofia

  1. Changed the company name so it is UTF-8 compatible, without this change the server would give an error loading the user page due to Expecting UTF-8 but getting ASCII-8BIT.

With the following command

#{Rails.application.config.x.company_name}

@lodewiges lodewiges changed the title edited the env file Edited the env file Nov 12, 2024
@lodewiges lodewiges enabled auto-merge November 12, 2024 14:29
ME_URL=/api/v1/users?filter[me]&include="active_groups"

COMPANY_NAME=Stichting Sociëteit Flux
COMPANY_NAME=Stichting Societeit Flux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have any visual impact? If not, ✔️ approved

@lodewiges lodewiges added this pull request to the merge queue Nov 24, 2024
Merged via the queue into staging with commit e3d1aa1 Nov 24, 2024
3 checks passed
@lodewiges lodewiges deleted the fix/env branch November 24, 2024 16:18
DrumsnChocolate added a commit that referenced this pull request Nov 29, 2024
* chore(deps): update dependency paranoia to v3 (#931)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Edited the env file (#944)

* edited the env file

* changed company name to UTF-8

* chore(deps): update dependency puma to '~> 6.4.0' [security] (#935)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/delete-package-versions action to v5 (#906)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency rails to v7.0.8.1 [security] (#918)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/build-push-action action to v6 (#928)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker/login-action action to v3 (#886)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(tests): add code coverage reporting (#891)

* feat(tests): add code coverage reporting

* fix: correct coverage path

* refactor: use simplecov-lcov

* fix: indentation in Gemfile.lock

* fix: remove test filters

* feat(README): add badge

* refactor: try tokenless report uploading

* chore: update codecov-action

* chore: update codecov-action

* fix(cd): pass CODECOV_TOKEN To ci

* Revert "chore(deps): update docker/login-action action to v3 (#886)" (#951)

This reverts commit d546681. due to CI failure

* chore(deps): update codecov/codecov-action action to v5 (#950)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency puma to v6.4.3 [security] (#948)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact action to v4 (#949)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Refractor/tomato to sofia (#947)

* Intial commit

* updated apliction.rb

* Fixed mistake in credentials

* Made it so the file is backwards compatiable

* Fixed a typo

* Update amber_oauth2.rb

remove tomato paramater

* Remove development title lux ad mosam (#946)

* intial commit

* Fix typo

* update tomato to sofia

* updated with suggestion

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: lodewiges <131907615+lodewiges@users.noreply.github.com>
Co-authored-by: Guido de Jong <35309288+guidojw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants