-
Notifications
You must be signed in to change notification settings - Fork 3
Remove development title lux ad mosam #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, you need to use a &&, no?
i.e.
a = 1
if a != 1 or a !=2:
<something>
then <something> will happen, while we actually want
!(a == 1 or a ==2) which is equivalent to a != 1 and a != 2
app/views/partials/_footer.html.erb
Outdated
| <% if Rails.application.config.x.tomato_host == 'stagingstreep.csvalpha.nl' %> | ||
| For demo and testing purposes only | ||
| <% elsif Rails.application.config.x.tomato_host != 'streep.csvalpha.nl' %> | ||
| <% elsif Rails.application.config.x.tomato_host != 'streep.csvalpha.nl' || Rails.application.config.x.tomato_host != 'luxstreep.csvalpha.nl' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <% elsif Rails.application.config.x.tomato_host != 'streep.csvalpha.nl' || Rails.application.config.x.tomato_host != 'luxstreep.csvalpha.nl' %> | |
| <% elsif Rails.application.config.x.tomato_host != 'streep.csvalpha.nl' && Rails.application.config.x.tomato_host != 'luxstreep.csvalpha.nl' %> |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #946 +/- ##
========================================
Coverage 52.37% 52.37%
========================================
Files 55 55
Lines 1178 1178
========================================
Hits 617 617
Misses 561 561 ☔ View full report in Codecov by Sentry. |
* chore(deps): update dependency paranoia to v3 (#931) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Edited the env file (#944) * edited the env file * changed company name to UTF-8 * chore(deps): update dependency puma to '~> 6.4.0' [security] (#935) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/delete-package-versions action to v5 (#906) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency rails to v7.0.8.1 [security] (#918) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update docker/build-push-action action to v6 (#928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update docker/login-action action to v3 (#886) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(tests): add code coverage reporting (#891) * feat(tests): add code coverage reporting * fix: correct coverage path * refactor: use simplecov-lcov * fix: indentation in Gemfile.lock * fix: remove test filters * feat(README): add badge * refactor: try tokenless report uploading * chore: update codecov-action * chore: update codecov-action * fix(cd): pass CODECOV_TOKEN To ci * Revert "chore(deps): update docker/login-action action to v3 (#886)" (#951) This reverts commit d546681. due to CI failure * chore(deps): update codecov/codecov-action action to v5 (#950) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency puma to v6.4.3 [security] (#948) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/upload-artifact action to v4 (#949) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Refractor/tomato to sofia (#947) * Intial commit * updated apliction.rb * Fixed mistake in credentials * Made it so the file is backwards compatiable * Fixed a typo * Update amber_oauth2.rb remove tomato paramater * Remove development title lux ad mosam (#946) * intial commit * Fix typo * update tomato to sofia * updated with suggestion --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: lodewiges <131907615+lodewiges@users.noreply.github.com> Co-authored-by: Guido de Jong <35309288+guidojw@users.noreply.github.com>
fixes #904