make start:preview script cross-platform by replacing ';' with '&&'#1354
make start:preview script cross-platform by replacing ';' with '&&'#1354dorothy122 wants to merge 2 commits into
Conversation
itsalaidbacklife
left a comment
There was a problem hiding this comment.
Looks good. Requesting to remove "node" from dependencies and then this is ready
| "lodash": "4.17.21", | ||
| "machinepack-passwords": "2.3.0", | ||
| "marked": "^16.4.1", | ||
| "node": "^24.15.0", |
There was a problem hiding this comment.
Node shouldn't be required as a dependency of the project. It's instead listed under "engines" below.
| "node": "^24.15.0", |
| "start:client": "vite --host", | ||
| "start:server": "node app.js", | ||
| "start:preview": "npm run build;npm run start:server", | ||
| "start:preview": "npm run build && npm run start:server", |
There was a problem hiding this comment.
Interesting catch. Do I take it you use cmd? I'd only used powershell when working with windows and that uses ; the same way bash does, so I'd never encountered this issue. It seems a noninvasive improvement to cross compatibility
|
As a last change, since you've updated a dependency, we need to update package-lock.json as well, which contains the exact versions of the full dependency tree. To do this, after removing node from package.json, please run |
|
@dorothy122 the need to update package-lock.json looks to be what caused the tests to fail since First, remove |
Issue number
Relevant issue number
Please check the following
Please describe additional details for testing this change
npm run build;npm run start:serverbut this failed on Windows. So I have changed the ; to && so that it should run on all platforms. I have tested this on Windows but not on any other platforms.