Skip to content

make start:preview script cross-platform by replacing ';' with '&&' #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dorothy122 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

make start:preview script cross-platform by replacing ';' with '&&' #1354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cd692
make start:preview script cross-platform by replacing ';' with '&&'
dorothy122 Apr 28, 2026
c3f670b
Merge branch 'main' into main
itsalaidbacklife May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"lodash": "4.17.21",
"machinepack-passwords": "2.3.0",
"marked": "^16.4.1",
"node": "^24.15.0",
Copy link
Copy Markdown
Contributor

@itsalaidbacklife itsalaidbacklife Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node shouldn't be required as a dependency of the project. It's instead listed under "engines" below.

Suggested change
"node": "^24.15.0",

"pinia": "2.2.4",
"rollbar": "^2.26.5",
"sails": "^1.5.15",
Expand Down Expand Up @@ -51,7 +52,7 @@
"storybook": "7.6.0",
"supertest": "^7.1.4",
"vite": "^7.1.12",
"vite-plugin-vue-devtools": "^8.0.3",
"vite-plugin-vue-devtools": "^8.1.1",
"vite-plugin-vuetify": "^2.1.2",
"vitest": "^4.0.5",
"vue-eslint-parser": "^10.2.0"
Expand All @@ -74,7 +75,7 @@
"start:serve": "vite preview",
"start:client": "vite --host",
"start:server": "node app.js",
"start:preview": "npm run build;npm run start:server",
"start:preview": "npm run build && npm run start:server",
Copy link
Copy Markdown
Contributor

@itsalaidbacklife itsalaidbacklife Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting catch. Do I take it you use cmd? I'd only used powershell when working with windows and that uses ; the same way bash does, so I'd never encountered this issue. It seems a noninvasive improvement to cross compatibility

"start:dev": "concurrently \"npm run start:client\" \"npm run start:server\"",
"start": "node app.js",
"build": "vite build",
Expand Down
Loading