NodeManager as a static thread_local singleton is no more.#11816
Merged
daniel-larraz merged 5 commits intocvc5:mainfrom Apr 16, 2025
Merged
NodeManager as a static thread_local singleton is no more.#11816daniel-larraz merged 5 commits intocvc5:mainfrom
daniel-larraz merged 5 commits intocvc5:mainfrom
Conversation
daniel-larraz
requested changes
Apr 15, 2025
Contributor
daniel-larraz
left a comment
daniel-larraz
left a comment
There was a problem hiding this comment.
Just a minor fix: a comment needs to be removed.
daniel-larraz
approved these changes
Apr 16, 2025
yoni206
pushed a commit
to yoni206/cvc5
that referenced
this pull request
May 28, 2025
Co-authored-by: Daniel Larraz <daniel-larraz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Daniel Larraz daniel-larraz@users.noreply.github.com