Update CVC5 to fix the concurrency issues#480
Merged
kfriedberger merged 9 commits intomasterfrom May 17, 2025
Merged
Conversation
In this version the concurrency issues should be fixed
CVC5 now uses local terms and function declarations that are only valid in their own SolverContext
kfriedberger
changed the title
kfriedberger
approved these changes
May 17, 2025
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
the CVC5 developers now seem to have fixed their concurrency issues, and all references to the thread-local NodeManager have now been removed, see here. They have also implemented a fix for a separate race condition in the JNI bindings that was reported by us here. This means we should now be able to pass CVC5 terms and solver instances from one thread to another without running into any issues.
In this PR we updates the binaries to the latest daily release that includes the fixes. This will close #310 and #347. Issue #469 may also be fixed by it, but we should look at this separately.