Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented May 2, 2025

Description

This PR adds a change which cleans up parsl resources after convert is finished. I'm adding it after anecdotally noticing the executor process was remaining open and testing this within the following notebook (and gist backup).

Closes #211

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from gwaybio May 2, 2025 22:35
@d33bs d33bs marked this pull request as ready for review May 2, 2025 22:35
@d33bs
Copy link
Member Author

d33bs commented May 3, 2025

Thanks @gwaybio !

@d33bs d33bs merged commit 0ba5317 into cytomining:main May 3, 2025
10 checks passed
@d33bs d33bs deleted the graceful-dfk-cleanup branch May 3, 2025 11:40
This was referenced May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible Parsl manager persistence after CytoTable processing

2 participants