Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Sep 30, 2025

Description

A new release of duckdb==1.4.0 changes the API for .arrow() returns to use pyarrow.lib.RecordBatchReader instead of pyarrow.lib.Table. This PR uses fetch_arrow_table to make CytoTable compatible with these changes and be more opinionated about what data type is used internally. Without this change CytoTable will encounter errors with installations of the latest duckdb.

References #369
Required for #366
Required for #368

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from gwaybio September 30, 2025 18:08
@d33bs d33bs marked this pull request as ready for review September 30, 2025 18:09
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to stay ahead of this!

@d33bs
Copy link
Member Author

d33bs commented Sep 30, 2025

Thanks @gwaybio !

@d33bs d33bs merged commit 90ad5b8 into cytomining:main Sep 30, 2025
12 checks passed
@d33bs d33bs deleted the use-explicit-arrow-tables-duckdb branch September 30, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants