Fix TUI project matching#11
Merged
daaain merged 2 commits intodaaain:mainfrom Jul 30, 2025
kym6464:fix-tui-project
Merged
Conversation
- Tier 1: Exact path-based matching using convert_project_path_to_claude_dir() - Tier 2: Git repository root matching using GitPython - Tier 3: Fallback to relative path matching (preserves existing behavior) This fixes the issue where home directory projects would incorrectly match all subdirectories due to overly broad relative path matching. Now exact matches and git repo matches take priority over relative matches. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@daaain for review |
daaain
approved these changes
Jul 30, 2025
Owner
daaain
left a comment
daaain
left a comment
There was a problem hiding this comment.
Hey @kym6464, sorry for the late reply, I'm on holiday 🌴
Reviewed the changes and they look good, the only thing you could do is to remove the references like "existing behavior" and "original behavior" from comments as they only make sense in the context of the current commit, but it's not a huge deal.
I'm on my phone now so can't do a release, but will do later today or tomorrow.
Owner
|
Thanks Kamal, really appreciated! |
Contributor
Author
|
No problem, enjoy your holiday! |
cboos
added a commit
that referenced
this pull request
Mar 5, 2026
CodeRabbit items considered and intentionally not changed: #8 (dag.md fenced blocks): No language identifiers on non-code blocks — project convention, not using markdownlint. #10 (dag.py:204 recursive → iterative): Max recursion depth is bounded by session message count. Python's default limit (1000) is more than sufficient for any real conversation. #11 (converter.py:463 queue ops at tail): Queue operations are metadata entries, not user-visible conversation content. Appending at tail is the intended behavior. #12 (renderer.py:2012 current_render_session leak): By design — branch context applies to all subsequent messages until the next line start. The variable is reset when a new DAG-line starts. #13 (session_nav.html:28 fork rows in expandable mode): Non-issue. Fork/branch nav items only appear in ToC mode (combined transcript and individual session pages). Expandable mode is only used in the project index page where fork items wouldn't be generated. Verified that individual session pages DO correctly include fork/branch nav. #14 (message_styles.css:901 font quoting): Cosmetic stylelint preference, no stylelint configured in this project. #15 (test_dag.py:44 error handling): Test helper — should fail loudly on bad test data, not silently skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug outlined in #10 in this comment
Testing
_before.mov
_after.mov
Notes
Adds GitPython as a dependency in order to find the root git repository