Make it possible to get to project selector in TUI even if pwd is a project + Github releases + fixes

[daaain]

No description provided.

[daaain]

@claude please review, I know it's a bit of a mixed bag of different things, but just getting into the flow with putting stuff in PRs first

[claude]

Claude finished @daaain's task —— View job

---

PR Review: Make it possible to get to project selector in TUI even if pwd is a project + GitHub releases + fixes

Thanks for the PR! As you mentioned, it's a "mixed bag" of features, but they're all valuable improvements. Here's my review:

Review Tasks

• Review CI/workflow changes for GitHub releases
• Analyze TUI improvements for project selector accessibility
• Check CLI modifications and new functionality
• Review cache system updates
• Assess test coverage and new test data
• Provide comprehensive feedback

✅ Strengths

1. TUI Project Navigation (claude_code_log/tui.py:101-110, cli.py:354-414)

   • Excellent solution for the project selector accessibility issue
   • The p key binding is intuitive and consistent with other shortcuts
   • Loop-based navigation flow is clean and works well

2. GitHub Releases Automation (justfile:214-354)

   • Comprehensive release workflow from version bump to GitHub release
   • Smart changelog extraction and formatting
   • Preview capability is a nice touch
   • Automatic artifact uploads are well implemented

3. Cache System Enhancements

   • Timestamp-based structure for efficient date filtering
   • Proper handling of no-timestamp entries (summaries)
   • Working directory tracking for project matching

4. VS Code Settings (.vscode/settings.json)

   • Good practice to exclude generated/cache files from search
   • Reduces noise when searching the codebase

🔍 Areas for Improvement

1. Mixed Concerns in PR

   • While the features work well, consider splitting large PRs like this into separate ones for easier review and rollback if needed
   • Could have been: 1) TUI improvements, 2) GitHub releases, 3) Cache/fixes

2. Documentation Updates

   • README.md changes are minimal considering the new features
   • Consider adding documentation for:
     • The new p keyboard shortcut in TUI
     • GitHub release process for maintainers
     • Cache structure and benefits

3. Test Coverage

   • Good test updates for TUI functionality
   • However, no tests for the new GitHub release functionality in justfile
   • Consider adding integration tests for cache timestamp filtering

4. Error Handling

   • In cli.py:106-113, cache building failures silently fall back to path matching
   • Consider logging these failures for debugging

5. VS Code Settings JSON Syntax

   • There's a trailing comma on line 7 which may cause issues in some JSON parsers

🐛 Potential Issues

1. Cache Invalidation (cli.py:102-114)

   • Building cache automatically when empty could be slow for large projects
   • Consider adding a progress indicator or making this async

2. Working Directory Matching (cli.py:119-126)

   • The bi-directional is_relative_to check could match unintended directories
   • Example: /home/user/project would match both /home/user and /home/user/project/subdir

3. Release Process (justfile:208-211)

   • The release-push command runs GitHub release creation after PyPI push
   • If GitHub release fails, the package is already on PyPI (inconsistent state)
   • Consider reversing order or adding rollback capability

💡 Suggestions

1. TUI Enhancement

   • Consider adding a visual indicator in the session browser that the p key is available
   • Maybe in the footer or help text?

2. Cache Performance

   • For large projects, consider implementing incremental cache updates
   • Only rebuild entries for modified files rather than full rebuild

3. Release Notes

   • The changelog extraction could be enhanced to support different formatting styles
   • Consider supporting conventional commits format

4. Type Hints

   • Some of the new functions could benefit from more specific type hints
   • Example: find_projects_by_cwd return type could be more specific

Overall Assessment

This PR successfully implements the main feature (TUI project selector accessibility) and adds valuable GitHub release automation. The code quality is good, and the implementation is thoughtful. The cache improvements are particularly well done with the timestamp-based structure.

The main concern is the PR scope - mixing multiple features makes it harder to review and potentially debug issues later. For future PRs, consider keeping them more focused on a single feature or closely related changes.

Great work on improving the user experience with the TUI navigation and automating the release process! 👍