Skip to content

Fix daily tests by excluding new deno validator#1642

Merged
yarikoptic merged 1 commit intodandi:masterfrom
CodyCBakerPhD:patch-1
May 27, 2025
Merged

Fix daily tests by excluding new deno validator#1642
yarikoptic merged 1 commit intodandi:masterfrom
CodyCBakerPhD:patch-1

Conversation

@CodyCBakerPhD
Copy link
Contributor

Discovered with @asmacdo, seeing if this works

@CodyCBakerPhD
Copy link
Contributor Author

Also looks like I am not added to this repo, thus contributing from fork for now

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.83%. Comparing base (5b813d4) to head (ca3981d).
⚠️ Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
- Coverage   88.84%   88.83%   -0.01%     
==========================================
  Files          82       82              
  Lines       11434    11438       +4     
==========================================
+ Hits        10158    10161       +3     
- Misses       1276     1277       +1     
Flag Coverage Δ
unittests 88.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmacdo
Copy link
Member

asmacdo commented May 27, 2025

dandi-archive's cli-integration tests are failing but only 1 failure, instead of the 17 i encountered.
dandi/dandi-archive#2391

@asmacdo
Copy link
Member

asmacdo commented May 27, 2025

Just as a sanity check I reran on a nearly-vanilla branch which is still failing, so I think this PR is needed. #1643

@CodyCBakerPhD
Copy link
Contributor Author

Temporary solution until @candleindark addresses test adjustments in solution to #1626

@yarikoptic yarikoptic added the patch Increment the patch version when merged label May 27, 2025
@yarikoptic yarikoptic merged commit 444e8b4 into dandi:master May 27, 2025
28 of 29 checks passed
candleindark added a commit to candleindark/dandi-cli that referenced this pull request May 27, 2025
@github-actions
Copy link

🚀 PR was released in 0.69.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants