Handle new exit behavior and validation result of the BIDS validator#1644
Merged
yarikoptic merged 5 commits intodandi:masterfrom May 30, 2025
Merged
Handle new exit behavior and validation result of the BIDS validator#1644yarikoptic merged 5 commits intodandi:masterfrom
yarikoptic merged 5 commits intodandi:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 88.75% 88.82% +0.07%
==========================================
Files 82 82
Lines 11438 11440 +2
==========================================
+ Hits 10152 10162 +10
+ Misses 1286 1278 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
candleindark
changed the title
candleindark
changed the title
candleindark
force-pushed
the
update-bids-validator
branch
from
093b7d2 to
1f399f7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BIDS validator integration to handle new exit behaviors and output changes introduced in version 2.0.6, including updated error handling and a change in the type of the age field.
- Tests now parameterize expected exit codes and error messages based on the validator version.
- The validator module conditionally checks exit codes and stderr based on the version.
- The models have been refactored to use a shared base model and update the age field type.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dandi/tests/test_bids_validator_deno/test_validator.py | Adjusted test parameters based on validator version changes |
| dandi/bids_validator_deno/_validator.py | Added version-specific checks for error conditions |
| dandi/bids_validator_deno/_models.py | Refactored models to use a base model and updated the age field type |
candleindark
force-pushed
the
update-bids-validator
branch
from
1f399f7 to
dfb4304
Compare
BIDS validator has a new exit behavior in 2.0.6, this commit put in changes that handles this new behavior correctly. For info about the new exit behavior, check out bids-standard/bids-validator#196
The new version of BIDS validator, at 2.0.6, returns `age` in `SubjectMetadata` as a float
Undoing the temp fix of dandi#1642
candleindark
force-pushed
the
update-bids-validator
branch
from
dfb4304 to
e5cb294
Compare
Member
Author
|
@CodyCBakerPhD I am requesting your review as well since I think you are familiar with the related code. |
candleindark
added
patch
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIDS validator has new exit behavior and a slightly different validation result output in 2.0.6, this commit put in changes that handles the new behavior and the output correctly. For info about the new return behavior, check out bids-standard/bids-validator#196. The change in the validation output is the
agefield inSubjectMetadatais now an decimal number instead of an integer.This PR closes #1626 and undoes the temporary fix provided by #1642.
Additionally, this PR also includes some minor refactoring of the models defined in
dandi/bids_validator_deno/_validator.py. Please see the individual commit for details.