Skip to content

Conversation

@firewave
Copy link
Collaborator

Check is used to store the check instances which are being accessed. The code/interface for the actual implementation of a Check does not need to be exposed. This will also get rid of the ambiguity of the objects of the same type.

@firewave
Copy link
Collaborator Author

firewave commented Aug 13, 2023

@danmar Please have a look.

I just did it for a small check so the idea is more visible. The final change will unfortunately be quite monolithic as this cannot be done is smaller steps (at least not ones which will compile).

For the most checks it should be straightforward since they do not expose any public functions. We also need to adjust how we call the tests for some checks which can be done in a separate PR beforehand - that might be the changes which might cause the most problems.

FYI This will make several other cleanups I attempted in local branches and #4695 obsolete.

@firewave
Copy link
Collaborator Author

firewave commented Apr 4, 2025

A side note - outside of the tests we would actually not require any of the checks to have headers at all since the application code is only accessing them through the instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant