got rid of global CTU::maxCtuDepth
#6892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
CTU::maxCtuDepth [skip ci]CTU::maxCtuDepth
firewave
commented
Oct 10, 2024
| int temp = 0; | ||
| if (!parseNumberArg(argv[i], 16, temp)) | ||
| return Result::Fail; | ||
| if (temp > 10) { |
Collaborator
Author
There was a problem hiding this comment.
I would like to keep this cap for a few versions (with a deprecation) because users might have specified a higher value and removing it would lead to different behavior and possibly decreased performance.
That cap previously lived in the function findPath() in lib/ctu.cpp.
firewave
force-pushed
the
ctu
branch
2 times, most recently
from
be3f996 to
307909f
Compare
Collaborator
Author
|
The initial changes exposes some currently horrible design with the checks having |
danmar
approved these changes
Oct 16, 2024
Collaborator
Author
|
I filed https://trac.cppcheck.net/ticket/13237 about removing this limitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.