Added the ability to retrieve url from BaseResponse#623
Added the ability to retrieve url from BaseResponse#623elmoiv wants to merge 10 commits intodart-lang:masterfrom
url from BaseResponse#623Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Add some documentation to the parameter and the field? Why are you adding this? How does it help you? |
|
It comes in handy when working with redirected urls. Like if I want to get the final retrieved URL after all redirects are done. This adds the ability to get that from a This was inspired from Python |
|
It appears that Dart CI Chrome tests are broken. |
Closes #321, closes #623, closes #692 Fixes #293 Add a Uri field to BaseResponse with the final, potentially redirected, url for the content. The field is nullable for backwards compatibility - TODO: consider if this should be non-nullable from the start, or if it can be published nullable first and become non-nullable (and the constructor arg required) in the next breaking release. This may break tests which use bocks but do not mock the field used to read the URL.
|
If we are able to roll out this feature I think we'll use a |
No description provided.