Conversation
Closes #321, closes #623, closes #692 Fixes #293 Add a Uri field to BaseResponse with the final, potentially redirected, url for the content. The field is nullable for backwards compatibility - TODO: consider if this should be non-nullable from the start, or if it can be published nullable first and become non-nullable (and the constructor arg required) in the next breaking release. This may break tests which use bocks but do not mock the field used to read the URL.
Member
Author
|
This is going to need more validation and potentially a rollout plan. |
This was referenced May 25, 2022
|
Thankyou !! |
|
Hello, could you please update on the status of this PR? We faced the issue in our project that getting the final redirected URL is not possible from http.Response. It would be great to have this functionality. Thanks! |
natebosch
added
the
next-breaking-release
Member
Author
|
This is blocked on a breaking version change. |
|
Any update on this? |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321, closes #623, closes #692
Fixes #293
Add a Uri field to BaseResponse with the final, potentially redirected,
url for the content.
The field is nullable for backwards compatibility - TODO: consider if
this should be non-nullable from the start, or if it can be published
nullable first and become non-nullable (and the constructor arg
required) in the next breaking release.
This may break tests which use mocks but do not mock the field used to
read the URL.