feat: deduplicate keywords automatically before trying to register token

[thephez]

Uses a hash set to make sure the token keyword list is unique (automatically excludes duplicates).

Closes #275

Summary by CodeRabbit

• Bug Fixes
  • Improved keyword handling to remove duplicate entries from token search keywords, ensuring more accurate and efficient search results.

[coderabbitai]

Walkthrough

A deduplication step was added to the parse_token_build_args method in TokensScreen. After collecting keywords, the code now uses a HashSet to ensure that the contract_keywords vector contains only unique entries, preventing duplicate keywords from being processed further.

Changes

File(s)	Change Summary
src/ui/tokens/tokens_screen.rs	Added deduplication of contract_keywords using a HashSet in parse_token_build_args.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent duplicate keyword error by deduplicating keywords internally (#275)	✅

Poem

In the garden of code, where keywords grow,
Duplication once caused a troublesome woe.
With a hop and a skip, a HashSet appears,
Now unique words bloom, no more error tears.
🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 562d6ce and ffeaa25.

📒 Files selected for processing (1)

• src/ui/tokens/tokens_screen.rs (1 hunks)

🔇 Additional comments (1)

src/ui/tokens/tokens_screen.rs (1)

4172-4175: Excellent enhancement: Deduplicating keywords prevents redundant processing.

This implementation efficiently removes duplicate keywords using a HashSet, ensuring each keyword is only processed once during token registration. This is a clean solution that prevents potential issues when the same keywords appear multiple times through different sources (manual entry and searchable token names).

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[thephez]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[pauldelucia]

I think it would be better to throw an error in the UI rather than quietly removing the duplicate keyword @thephez

[thephez]

I think it would be better to throw an error in the UI rather than quietly removing the duplicate keyword @thephez

If we throw an error it needs to be clear as to why it's present. The error currently reported is not clear when it's due to clicking Searchable AND putting the token name in the keyword list. This is because it's not intuitively obvious that the "Searchable" checkbox adds the token name to the keyword list - the UI doesn't show this. It took me about 15 minutes to figure out that was what was happening.

What do you think the error message should be? IMO there probably would need to be at least 2 error messages. One for the case where the error is happening because they've checked the Searchable box and one for everything else.

[pauldelucia]

See above

[pauldelucia]

#279