fix: show error if duplicate contract keywords in creator#279
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This is definitely better. I still find the checkbox somewhat mysterious, but I can live with it. 🙂 |
| ui.label("(plural):"); | ||
| ui.text_edit_singleline(&mut self.token_names_input[i].1); | ||
| }); | ||
| ui.text_edit_singleline(&mut self.token_names_input[i].0); |
There was a problem hiding this comment.
As per description:
The whole Searchable token name thing was very confusing. Gave the checkbox a new label and also checked for duplicate keywords and displayed error.
All I see is that the plural was removed, nothing about duplicate keywords.
There was a problem hiding this comment.
See further down for that part (around comment "// If there are any duplicate keywords, show an error")
The whole Searchable token name thing was very confusing. Gave the checkbox a new label and also checked for duplicate keywords and displayed error.