fix: dash-qt path autodetection fails

[lklimek]

Issue

dash-qt path is not correctly autodetected

Solution

Refactored settings handling to make it easier to manage dash-qt path (and others).

Details

This pull request refactors the handling of application settings by introducing a new Settings struct and centralizing its usage across the codebase. The changes simplify the code, improve readability, and enhance maintainability by replacing complex tuple-based settings with a structured approach. Additionally, redundant code for detecting the Dash-Qt binary path has been consolidated into the Settings struct.

Refactoring and centralization of settings:

• Introduced a new Settings struct in src/model/settings.rs to encapsulate application settings, replacing tuple-based settings. Includes methods for creating, converting, and defaulting settings, along with logic for Dash-Qt path detection.
• Updated AppContext::get_settings in src/context.rs to return the new Settings struct instead of a tuple, simplifying database operations.
• Replaced tuple-based settings logic with structured Settings usage in AppState initialization in src/app.rs. This includes extracting individual settings like password_info, theme_mode, and dash_qt_path directly from the Settings struct. [1] [2]

Removal of redundant code:

• Removed the standalone detect_dash_qt_path function from src/app.rs and integrated its functionality into the Settings struct. This consolidates Dash-Qt path detection logic and eliminates duplication.

Updates to UI components:

• Refactored the logic in various UI components (dpns_subscreen_chooser_panel, tokens_subscreen_chooser_panel, tools_subscreen_chooser_panel) to use Settings::root_screen_type instead of accessing tuple indices. [1] [2] [3]
• Enhanced NetworkChooserScreen in src/ui/network_chooser_screen.rs to utilize Settings for theme preference and Dash-Qt path, and added validation for Dash-Qt binary path before enabling the "Start" button. [1] [2] [3] [4]

These changes improve the codebase's clarity and modularity, making it easier to maintain and extend in the future.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR centralizes application settings by introducing a Settings struct, consolidates Dash-Qt path autodetection into that struct, and updates UI components to use the new structured settings API.

• Introduced Settings in src/model/settings.rs with built-in Dash-Qt path detection.
• Changed AppContext::get_settings and application initialization to return and consume Settings instead of raw tuples.
• Updated UI modules (network_chooser_screen, subscreen chooser panels) to reference Settings properties and added validation for the Start button.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/model/settings.rs	Added Settings struct, removed standalone detect_dash_qt_path.
src/context.rs	Changed get_settings to return Option<Settings>.
src/app.rs	Refactored AppState initialization to use Settings, removed dead code.
src/ui/network_chooser_screen.rs	Loaded theme and Dash-Qt path from Settings, replaced tuple logic, added Start button validation.
src/ui/components/tools_subscreen_chooser_panel.rs	Switched from tuple index to settings.root_screen_type.
src/ui/components/tokens_subscreen_chooser_panel.rs	Switched from tuple index to settings.root_screen_type.
src/ui/components/dpns_subscreen_chooser_panel.rs	Switched from tuple index to settings.root_screen_type.
src/model/mod.rs	Registered the new settings module.

Comments suppressed due to low confidence (5)

src/model/settings.rs:13

• The comment refers to an "Empty string," but the field is Option<PathBuf>. Update it to explain that Some(PathBuf::new()) (an empty PathBuf) disables autodetection.

    /// Path to the Dash-Qt binary, if set. None means autodetect. Empty string means no path set and no autodetect.

src/context.rs:487

• The tuple element is destructured into developer_mode but represents overwrite_dash_conf from the database. Rename this variable to overwrite_dash_conf for clarity.

            dash_qt_path,

src/ui/network_chooser_screen.rs:585

• [nitpick] Consider rephrasing and capitalizing consistently, e.g., "Please configure the Dash-Qt binary path in Advanced Settings." for clarity.

                        "Please select path to dash-qt binary in Advanced Settings",

src/ui/network_chooser_screen.rs:574

• Add unit tests to cover the start_enabled logic (empty path vs valid file) to ensure the button enabling behaves as expected.

        let start_enabled = if let Some(path) = self.custom_dash_qt_path.as_ref() {

src/ui/network_chooser_screen.rs:16

• The imported NixPath isn't used anywhere in this file. Consider removing this import to keep the code clean.

use nix::NixPath;