fix: top up with qr code wasnt working

[pauldelucia]

There were a few issues.

It wasn't even displaying to begin with because of an early return.

Then it was automatically saying "No wallet selected"

Then the QR code wasn't working - it had Dash Core sending funds to itself.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes the QR code top-up flow by displaying the QR step properly, importing the Dash Core address dynamically, and validating the funding amount before rendering the QR.

• Display “AddressWithQRCode” step with an info tooltip
• Replace core_has_funding_address flag with dynamic get_address_info check and import
• Validate and handle invalid or zero amounts before calling render_qr_code

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/ui/identities/top_up_identity_screen/mod.rs	Adds UI block for the QR code funding method and tooltip
src/ui/identities/top_up_identity_screen/by_wallet_qr_code.rs	Refactors QR code rendering: dynamic import, amount checks, and error handling

Comments suppressed due to low confidence (2)

src/ui/identities/top_up_identity_screen/by_wallet_qr_code.rs:32

• [nitpick] The variable name info is ambiguous. Consider renaming it to address_info for clarity.

                        .get_address_info(&receive_address)

src/ui/identities/top_up_identity_screen/by_wallet_qr_code.rs:53

• [nitpick] The error message "No wallet selected" may not provide sufficient guidance to the user. Consider making it more descriptive, e.g., "Please select a wallet to generate a QR code."

                return Err("No wallet selected".to_string());

[Copilot]

[nitpick] The long tooltip string makes the UI code verbose and harder to read. Consider extracting this text into a named constant or external resource for clarity and easier localization.

Suggested change

	"The selected wallet will be used to:\n\n\
	• Generate a receive address for the QR code\n\
	• Hold the private keys needed to create the asset lock transaction\n\
	• Sign and broadcast the transaction to top up your identity\n\n\
	The wallet must have control over the funds to create the asset lock \
	that credits your identity on the Dash Platform.",
	TOOLTIP_TEXT,

[Copilot]

Using expect on a lock acquisition can cause a panic if the lock is poisoned. Consider propagating this error gracefully or handling lock poisoning to avoid unexpected crashes.

Suggested change

	.expect("Core client lock was poisoned");
	.map_err(|_| "Core client lock was poisoned".to_string())?;