Skip to content

fix(ui): include identity name in auth key error message#746

Closed
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix/identity-name-in-auth-key-error
Closed

fix(ui): include identity name in auth key error message#746
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix/identity-name-in-auth-key-error

Conversation

@thepastaclaw
Copy link
Copy Markdown
Collaborator

Summary

When an identity lacks an authentication key for signing document transitions, the error banner now includes the identity alias (or base58 ID if no alias) so users can tell which identity has the issue.

Before: Identity doesn't have an authentication key for signing document transitions
After: Identity 'MyEvonode' doesn't have an authentication key for signing document transitions

This is especially helpful for users with many identities (the reporter has 16).

Closes #743

Changes

  • src/ui/identities/mod.rs: Use format!() with display_string() instead of static string
  • src/backend_task/identity/register_dpns_name.rs: Same — also switched from .ok_or() to .ok_or_else() to avoid eager allocation

When an identity lacks an authentication key for signing document
transitions, the error banner now includes the identity alias or ID
so users can identify which of their identities has the issue.

Closes dashpay#743
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e4f5469-55fb-41b7-9868-b6d7b6e4e21e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Copy Markdown
Collaborator Author

Superseded by #750 which includes this fix plus suppresses the error on startup auto-select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity doesn't have an authentication key for signing document transitions

1 participant