Skip to content

fix(ui): improve auth key error message and suppress on startup auto-select#750

Closed
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix-startup-auth-key-error
Closed

fix(ui): improve auth key error message and suppress on startup auto-select#750
thepastaclaw wants to merge 1 commit into
dashpay:v1.0-devfrom
thepastaclaw:fix-startup-auth-key-error

Conversation

@thepastaclaw
Copy link
Copy Markdown
Collaborator

Issue

Closes #743 — On startup, DET shows a confusing "Identity doesn't have an authentication key for signing document transitions" error banner with no indication of which identity is affected.

Changes

  1. Better error message: Include the identity alias/DPNS name and ID in the error, so users with multiple identities can identify which one lacks a signing key.

    Before: Identity doesn't have an authentication key for signing document transitions
    After: Identity 'my-evonode' (7xK3...) doesn't have an authentication key for signing document transitions

  2. Suppress banner on auto-select: The ContactRequests and QRCodeGenerator screens auto-select the first identity during construction. If that identity lacks a document signing key (e.g., evonode identities), the error was shown immediately before the user did anything. Now these screens silently set wallet to None on auto-select — the error only appears when the user explicitly selects an identity that lacks the key.

Testing

  • cargo check — clean
  • cargo clippy — clean
  • cargo fmt — clean

…select

- Include identity alias/name and ID in the error message so users with
  multiple identities can identify which one lacks a signing key
- Don't show error banner during automatic first-identity selection on
  screen construction (ContactRequests, QRCodeGenerator) since identities
  like evonodes may legitimately lack document signing keys

Closes dashpay#743
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8fc4f83a-7d09-402f-b4d9-6cb2874492a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lklimek
Copy link
Copy Markdown
Contributor

lklimek commented Mar 15, 2026

Error handling refactoring was merged to v1.0-dev. claw please check if the issues are still present, and recreate on top of v1.0-dev if needed.

@thepastaclaw
Copy link
Copy Markdown
Collaborator Author

All three issues are still present on v1.0-dev after the error handling refactor (#739). Recreated the fixes on top of v1.0-dev in #761.

Closing this one in favor of #761.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identity doesn't have an authentication key for signing document transitions

2 participants