fix(ui): improve auth key error message and suppress on startup auto-select#750
fix(ui): improve auth key error message and suppress on startup auto-select#750thepastaclaw wants to merge 1 commit into
Conversation
…select - Include identity alias/name and ID in the error message so users with multiple identities can identify which one lacks a signing key - Don't show error banner during automatic first-identity selection on screen construction (ContactRequests, QRCodeGenerator) since identities like evonodes may legitimately lack document signing keys Closes dashpay#743
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Error handling refactoring was merged to v1.0-dev. claw please check if the issues are still present, and recreate on top of v1.0-dev if needed. |
Issue
Closes #743 — On startup, DET shows a confusing "Identity doesn't have an authentication key for signing document transitions" error banner with no indication of which identity is affected.
Changes
Better error message: Include the identity alias/DPNS name and ID in the error, so users with multiple identities can identify which one lacks a signing key.
Before:
Identity doesn't have an authentication key for signing document transitionsAfter:
Identity 'my-evonode' (7xK3...) doesn't have an authentication key for signing document transitionsSuppress banner on auto-select: The ContactRequests and QRCodeGenerator screens auto-select the first identity during construction. If that identity lacks a document signing key (e.g., evonode identities), the error was shown immediately before the user did anything. Now these screens silently set wallet to
Noneon auto-select — the error only appears when the user explicitly selects an identity that lacks the key.Testing
cargo check— cleancargo clippy— cleancargo fmt— clean