fix: Improve quorum data caching and cleanup#5731
Merged
PastaPastaPasta merged 10 commits intoNov 29, 2023
Merged
Conversation
UdjinM6
changed the title
UdjinM6
changed the title
UdjinM6
force-pushed
the
fix_quorum_data_cleanup
branch
from
27dadec to
0b801c6
Compare
5 tasks
UdjinM6
requested review from
PastaPastaPasta and
ogabrielides
and removed request for
ogabrielides
… and the number of keys to keep
ogabrielides
suggested changes
Nov 26, 2023
ogabrielides
left a comment
ogabrielides
left a comment
There was a problem hiding this comment.
Looks good in general, some change though:
knst
reviewed
Nov 27, 2023
PastaPastaPasta
pushed a commit
that referenced
this pull request
Nov 27, 2023
#5732) ## Issue being fixed or feature implemented #4788 (comment) noticed while working on #5731 ## What was done? ## How Has This Been Tested? run a node, check logs - there is a meaningful time span between `start` and `done` now and not just zeros all the time. ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
PastaPastaPasta
previously approved these changes
Nov 27, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
5 tasks
PastaPastaPasta
approved these changes
Nov 28, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Collaborator
CI still failed after I restarted it |
Now it succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: