Skip to content

ci: Free disk space by removing no longer needed build files#7010

Merged
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:ci_drop_build_ci
Dec 4, 2025
Merged

ci: Free disk space by removing no longer needed build files#7010
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:ci_drop_build_ci

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Nov 26, 2025

Issue being fixed or feature implemented

Some CI src builds started to fail for me with No space left on device https://github.com/UdjinM6/dash/actions/runs/19684695976/job/56395728306

What was done?

Free disk space by removing heavy no longer needed build files, they are excluded in bundle-artifacts.sh anyway

How Has This Been Tested?

https://github.com/UdjinM6/dash/actions/runs/19704232668

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 23.1 milestone Nov 26, 2025
@github-actions
Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 26, 2025

Walkthrough

The change introduces cleanup steps to a GitHub Actions workflow that remove static library files (*.a) and object files (*.o) from the build-ci/dashcore-${BUILD_TARGET}/src/ directory prior to bundling artifacts. This cleanup executes before the bundle-artifacts.sh script runs, ensuring build intermediates are not included in the final bundle.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify the file patterns (*.a and *.o) are appropriate for the cleanup scope
  • Confirm the directory path build-ci/dashcore-${BUILD_TARGET}/src/ is correctly specified and matches the actual build structure

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing unneeded build files to free disk space in CI, which directly addresses the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the disk space issue, the solution implemented, and providing test evidence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a2c14b and 35d2e2b.

📒 Files selected for processing (1)
  • .github/workflows/build-src.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
{guix-build*,releases,**/guix-build*,releases/**,.github/**,depends/**,ci/**,contrib/**,doc/**}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted

Files:

  • .github/workflows/build-src.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: linux64_tsan-build / Build source
  • GitHub Check: x86_64-w64-mingw32 / Build depends
  • GitHub Check: Lint / Run linters
  • GitHub Check: x86_64-pc-linux-gnu_nowallet / Build depends
  • GitHub Check: x86_64-apple-darwin / Build depends
  • GitHub Check: x86_64-pc-linux-gnu / Build depends
  • GitHub Check: arm-linux-gnueabihf / Build depends
🔇 Additional comments (1)
.github/workflows/build-src.yml (1)

111-112: Appropriate disk space cleanup with proper sequencing.

The added cleanup commands remove intermediate build artifacts (static libraries and object files) that are not needed in the final bundle, executed at the right point in the workflow—after unit tests but before bundling.

One clarification: While coding guidelines typically restrict changes to .github/ workflows, your PR is explicitly prompted and addresses an operational necessity (resolving "No space left on device" failures). This is an appropriate exception.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 35d2e2b

@UdjinM6 UdjinM6 requested a review from knst November 30, 2025 21:19
Copy link
Copy Markdown
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 35d2e2b

@PastaPastaPasta PastaPastaPasta merged commit c2c2273 into dashpay:develop Dec 4, 2025
31 of 34 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

This pull request has conflicts, please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants