Skip to content

ci: free disk space by removing /output folder when it's no longer needed#7075

Merged
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:ci_drop_output
Dec 19, 2025
Merged

ci: free disk space by removing /output folder when it's no longer needed#7075
PastaPastaPasta merged 1 commit into
dashpay:developfrom
UdjinM6:ci_drop_output

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Dec 19, 2025

Issue being fixed or feature implemented

/output folder just sits there wasting disk space after Build source step:

  • multiprocess 0.6GB
  • ubsan 1.7GB
  • tsan 2.4GB
  • nowallet 2.6GB
  • arm-linux 2.7GB
  • linux64 and linux64_sqlite 3.3GB

(NOTE: fuzz, mac and win64 don't produce anything in /output folder)

What was done?

Remove the folder at the end of Build source step. Also drop unused BASE_OUTDIR env var pointing to it from Run unit tests step to avoid confusion.

How Has This Been Tested?

https://github.com/UdjinM6/dash/actions/runs/20355332620

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 23.1 milestone Dec 19, 2025
@github-actions
Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 19, 2025

Walkthrough

The GitHub Actions workflow file .github/workflows/build-src.yml was modified to enhance disk space management in the CI pipeline. Two new commands were added to the Build source step: one to probe disk usage of the output directory and another to remove the directory post-build. Additionally, the explicit initialization of BASE_OUTDIR="/output" was removed from the Run unit tests step, with the variable now set elsewhere in the workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward CI configuration modifications with minimal logic changes
  • Simple command additions for disk cleanup and monitoring
  • No complex interdependencies or multi-file impact

Possibly related PRs

Suggested reviewers

  • PastaPastaPasta
  • knst

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main objective: freeing disk space by removing the /output folder in CI, which aligns with the changeset modifications to the build workflow.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (wasted disk space), the solution (removing /output folder), and providing specific context about folder sizes and test results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bcb984 and 3c6da38.

📒 Files selected for processing (1)
  • .github/workflows/build-src.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
{guix-build*,releases,**/guix-build*,releases/**,.github/**,depends/**,ci/**,contrib/**,doc/**}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted

Files:

  • .github/workflows/build-src.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: linux64_nowallet-build / Build source
  • GitHub Check: linux64_tsan-build / Build source
  • GitHub Check: win64-build / Build source
  • GitHub Check: linux64-build / Build source
  • GitHub Check: linux64_sqlite-build / Build source
  • GitHub Check: linux64_ubsan-build / Build source
  • GitHub Check: linux64_fuzz-build / Build source
  • GitHub Check: mac-build / Build source
  • GitHub Check: arm-linux-build / Build source
  • GitHub Check: Lint / Run linters
🔇 Additional comments (1)
.github/workflows/build-src.yml (1)

102-103: The /output directory removal at lines 102-103 is safe. Verification confirms that subsequent CI steps (lint-tidy.sh, test_unittests.sh, bundle-artifacts.sh) do not reference /output or BASE_OUTDIR. All subsequent steps operate exclusively on build-ci/dashcore-${BUILD_TARGET} directories, making the removal a valid optimization to free disk space.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@UdjinM6 UdjinM6 mentioned this pull request Dec 19, 2025
5 tasks
Copy link
Copy Markdown
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3c6da38

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3c6da38

@PastaPastaPasta PastaPastaPasta merged commit 6fbe514 into dashpay:develop Dec 19, 2025
101 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants