chore(key-wallet-ffi): remove wallet_create_managed_wallet

[xdustinface]

Removes the FFI constructor that produced a state-empty FFIManagedWalletInfo with no persistence path. The proper way to obtain a FFIManagedWalletInfo is via wallet_manager_get_managed_wallet_info, which borrows from a persistent WalletManager.

Regenerates FFI_API.md.

Summary by CodeRabbit

• Documentation

  • Updated FFI API documentation reflecting reduction in available functions (from 259 to 258 total)

• Refactor

  • Removed wallet creation function from FFI interface

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e69cf8d-70b2-43d1-ba26-1ac300444def

📥 Commits

Reviewing files that changed from the base of the PR and between ca507a9 and fc98a64.

📒 Files selected for processing (2)

• key-wallet-ffi/FFI_API.md
• key-wallet-ffi/src/transaction_checking.rs

---

📝 Walkthrough

Walkthrough

An exported FFI function wallet_create_managed_wallet was removed from the transaction checking module, its unused import was cleaned up, and the auto-generated API documentation was updated to reflect the reduced function count.

Changes

FFI Function Removal

Layer / File(s)	Summary
Core Removal key-wallet-ffi/src/transaction_checking.rs	Exported FFI function wallet_create_managed_wallet is removed; the module now begins transaction checking exports with managed_wallet_check_transaction.
Import Cleanup key-wallet-ffi/src/transaction_checking.rs	Unused deref_ptr import from crate is removed following function deletion.
Documentation key-wallet-ffi/FFI_API.md	Total function count decreases from 259 to 258; Wallet Operations section count decreases from 64 to 63.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A function hops away today,
The FFI lighter, sleek, and clean,
One export less to clear the way,
Simplest code we've ever seen! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and concisely describes the primary change: removal of the wallet_create_managed_wallet FFI function, which is the main modification across all changed files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/remove-wallet-create-managed-wallet

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get your free trial and get 200 agent minutes per Slack user (a $50 value).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.60%. Comparing base (ca507a9) to head (fc98a64).

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.42-dev     #710      +/-   ##
=============================================
+ Coverage      70.58%   70.60%   +0.01%     
=============================================
  Files            320      320              
  Lines          68243    68235       -8     
=============================================
+ Hits           48168    48175       +7     
+ Misses         20075    20060      -15     

Flag	Coverage Δ
core	75.81% <ø> (ø)
ffi	43.41% <ø> (+0.03%)	⬆️
rpc	20.00% <ø> (ø)
spv	87.30% <ø> (+0.04%)	⬆️
wallet	69.63% <ø> (ø)

Files with missing lines	Coverage Δ
key-wallet-ffi/src/transaction_checking.rs	1.95% <ø> (+0.04%)	⬆️

... and 4 files with indirect coverage changes

[ZocoLini]

I just took a look and this IS being wrapped in the swift side but not used at all, it is just there making noise, like a lot of things, and now, since platform wallet is wrapping the SPV client and the core wallet operations we use, I don't know if it makes sense to have dash-spv-ffi and key-wallet-ffi at all